[umbrello] [Bug 400794] New: Move out ui options page code into separate class

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=400794

Bug ID: 400794
Summary: Move out ui options page code into separate class
Product: umbrello
Version: 2.26.2 (KDE Applications 18.08.2)
Platform: Other
OS: All
Status: REPORTED
Severity: normal
Priority: NOR
Component: general
Assignee: umbrello-***@kde.org
Reporter: ***@freenet.de
Target Milestone: ---

In the current implementation, the code for the Ui options page used by the
settings dialog is still embedded in SettingsDialog::setupUIPage(), while all
other pages are already in separate classes. This should be corrected.

STEPS TO REPRODUCE
1. inspect SettingsDialog::setupUIPage() at
https://cgit.kde.org/umbrello.git/tree/umbrello/dialogs/settingsdialog.cpp#n116

OBSERVED RESULT
The page code is embedded

EXPECTED RESULT
The page code should be moved out into a separate class


SOFTWARE VERSIONS
(available in About System)
KDE Plasma Version:
KDE Frameworks Version:
Qt Version:

ADDITIONAL INFORMATION

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=400794

Ralf Habacker <***@freenet.de> changed:

What |Removed |Added
----------------------------------------------------------------------------
Version Fixed In| |2.26.80 (KDE Applications
| |18.11.80)
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/umb
| |rello/a368b61e1e2e99fbb1127
| |47db207fb25eeee710d
Status|REPORTED |RESOLVED

--- Comment #1 from Ralf Habacker <***@freenet.de> ---
Git commit a368b61e1e2e99fbb112747db207fb25eeee710d by Ralf Habacker.
Committed on 07/11/2018 at 10:56.
Pushed by habacker into branch 'master'.

Move implementation for the UI options page to a separate class
FIXED-IN:2.26.80 (KDE Applications 18.11.80)

M +1 -0 umbrello/CMakeLists.txt
A +252 -0 umbrello/dialogs/pages/uioptionspage.cpp [License: GPL
(v2+)]
A +81 -0 umbrello/dialogs/pages/uioptionspage.h [License: GPL (v2+)]
M +5 -208 umbrello/dialogs/settingsdialog.cpp
M +3 -7 umbrello/dialogs/settingsdialog.h

https://commits.kde.org/umbrello/a368b61e1e2e99fbb112747db207fb25eeee710d