D17108: Fix regression on import of Java classes with methods using varargs

[Oliver Kellogg]

okellogg created this revision.
okellogg added a reviewer: habacker.
Herald added a subscriber: umbrello-devel.
Herald added a project: Umbrello.
okellogg requested review of this revision.

REVISION SUMMARY
In JavaImport::fillSource(), replace "..." occurring in the input word by "[]".
BUG: 401290

REPOSITORY
R139 Umbrello

REVISION DETAIL
https://phabricator.kde.org/D17108

AFFECTED FILES
umbrello/codeimport/javaimport.cpp

To: okellogg, habacker
Cc: umbrello-devel, astranieri

[Ralf Habacker]

habacker added a comment.


The title of this commit is inappropriate, because the patch does not fix the initially reported regression, but converts the java specific notation '...' into a language independent array definition.

BUG:292239

This patch does not close the actual reported problem, therefore
CCBUG:292239

Alternatively, an independent bug report could be submitted for this subproblem so that it appears as a separate entry in the list of fixed bugs for the next release 2.27 https://umbrello.kde.org/developers.php#changelog
In this case, FIXED-IN: should be added to the keywords:

BUG:XXX
FIXED-IN:2.26.90 (KDE Applications 18.11.90)

BTW: bug fixes without any translation related changes could be applied to the stable branch, which is currently Applications/18.12

REPOSITORY
R139 Umbrello

REVISION DETAIL
https://phabricator.kde.org/D17108

To: okellogg, habacker
Cc: umbrello-devel, astranieri

[Oliver Kellogg]

okellogg retitled this revision from "Fix regression on import of Java classes with methods using varargs " to "JavaImport: Convert Java specific notation '...' into a language independent array definition".
okellogg edited the summary of this revision.

REPOSITORY
R139 Umbrello

REVISION DETAIL
https://phabricator.kde.org/D17108

To: okellogg, habacker
Cc: umbrello-devel, astranieri

[Oliver Kellogg]

okellogg added a comment.


I changed the title as you suggest.
From my point of view, the wohle point of bug 401290 was to get rid of the annoying dialogs popping up.
So I would argue that this does on fact fix the issue, even in a way that has an improvement in portability as a side effect.

BTW: bug fixes without any translation related changes could be applied to the stable branch, which is currently Applications/18.12

Sure, go ahead. The patch applies cleanly there too.

REPOSITORY
R139 Umbrello

REVISION DETAIL
https://phabricator.kde.org/D17108

To: okellogg, habacker
Cc: umbrello-devel, astranieri

[Ralf Habacker]

habacker accepted this revision.
habacker added a comment.
This revision is now accepted and ready to land.


Another view is that this patch bypasses the originally described error (the dialog box).

REPOSITORY
R139 Umbrello

REVISION DETAIL
https://phabricator.kde.org/D17108

To: okellogg, habacker
Cc: umbrello-devel, astranieri