[umbrello] [Bug 391559] New: appdata id different from desktop file name

[Harald Sitter]

https://bugs.kde.org/show_bug.cgi?id=391559

Bug ID: 391559
Summary: appdata id different from desktop file name
Product: umbrello
Version: Git
Platform: Other
OS: Linux
Status: UNCONFIRMED
Severity: normal
Priority: NOR
Component: general
Assignee: umbrello-***@kde.org
Reporter: ***@kde.org
Target Milestone: ---

appdata has
<id>org.kde.umbrello.desktop</id>


desktop file is apparently named umbrello.desktop

the appdata also doesn't provide a launchable entry.

all in all I find it entirely unlikey that appstream will be able to properly
map the appdata to the desktop file. thus reducing the autogenerated
information in the appdata as a whole (e.g. it'd be missing categories)

the desktop file name needs to be changed to use reverse domain notation. RDN
is also needed for automatic wayland window-desktopid mapping, so renaming is
necessary to get that working anyway.

https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-launchable

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=391559

Ralf Habacker <***@freenet.de> changed:

What |Removed |Added
----------------------------------------------------------------------------

Post by Harald Sitter
desktop file is apparently named umbrello.desktop

you looked in git ?

With kf5 builds it in installed into /usr/share/applications
org.kde.umbrello.desktop, which is probably what you expected.

It would be the choice to rename the file in git repo, but this will not be
able in stable branch because of freezed translation state. Instead this would
be performed in master branch for 2.26 releases.

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=391559

--- Comment #2 from Ralf Habacker <***@freenet.de> ---
Git commit 163a0bed29d443a3456eeb019da2e0bc53535149 by Ralf Habacker.
Committed on 30/05/2018 at 11:45.
Pushed by habacker into branch 'Applications/18.04'.

Add <launchable> entry to umbrello appdata xml file

M +1 -0 umbrello/org.kde.umbrello.appdata.xml

https://commits.kde.org/umbrello/163a0bed29d443a3456eeb019da2e0bc53535149

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=391559

Ralf Habacker <***@freenet.de> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|UNCONFIRMED |RESOLVED
Version Fixed In| |2.25.80 (KDE Applications
| |18.07.80)
Latest Commit| |https://commits.kde.org/umb
| |rello/988fa1ecbfa0aac74912c
| |58f09180c12d539bb68

--- Comment #3 from Ralf Habacker <***@freenet.de> ---
Git commit 988fa1ecbfa0aac74912c58f09180c12d539bb68 by Ralf Habacker.
Committed on 30/05/2018 at 12:17.
Pushed by habacker into branch 'master'.

Use reverse domain notation for application desktop file name
FIXED-IN:2.25.80 (KDE Applications 18.07.80)

M +5 -8 umbrello/CMakeLists.txt
R +0 -0 umbrello/org.kde.umbrello.desktop [from:
umbrello/umbrello.desktop - 100% similarity]

https://commits.kde.org/umbrello/988fa1ecbfa0aac74912c58f09180c12d539bb68

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=391559

--- Comment #4 from Ralf Habacker <***@freenet.de> ---
Git commit 6796355a66da37b6b1a9d42e8eb63710298ed690 by Ralf Habacker.
Committed on 30/05/2018 at 12:35.
Pushed by habacker into branch 'master'.

Fixup of commit 988fa1ecbfa0aac74912c58f09180c12d539bb68

Patching binary name in appdata file has been removed and therefore
the binary name need to be updated in the app data file directly.

M +1 -1 umbrello/org.kde.umbrello.appdata.xml

https://commits.kde.org/umbrello/6796355a66da37b6b1a9d42e8eb63710298ed690