[umbrello] [Bug 394230] New: Listpopupmenu needs refactoring

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=394230

Bug ID: 394230
Summary: Listpopupmenu needs refactoring
Product: umbrello
Version: Git
Platform: Other
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: NOR
Component: general
Assignee: umbrello-***@kde.org
Reporter: ***@freenet.de
Blocks: 393188
Target Milestone: ---

While working on bug 393188 it turned out that finding the right place where
new context menu entries need to be added is hard hard work because of issues
with the current ListPopupMenu implementation.

1. It is not easy to see which constructor to use for which menu type (list
view, diagrams, widgets, dialogs and other)
2. The internal implementation only have a very limited separation (m_listView,
widget, umlobject). It is not easy to choose where to add entries for the
different source types (list view, diagrams, widgets, dialogs and other), which
results into having menu entries in unrelated menus.
3. The enum MenuType specifies separate menu entries, but the values from this
enum are also used to specify completes menus, which is confusing.


Referenced Bugs:

https://bugs.kde.org/show_bug.cgi?id=393188
[Bug 393188] Add feature to add connected note

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=394230

Ralf Habacker <***@freenet.de> changed:

What |Removed |Added
----------------------------------------------------------------------------
Version Fixed In| |2.25.80 (KDE Applications
| |18.07.80)
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/umb
| |rello/0bcf43aa0ff8a5cef2597
| |4917bf8513c0a679043

--- Comment #1 from Ralf Habacker <***@freenet.de> ---
Git commit 0bcf43aa0ff8a5cef25974917bf8513c0a679043 by Ralf Habacker.
Committed on 11/06/2018 at 18:52.
Pushed by habacker into branch 'master'.

Merge remote-tracking branch 'gitlab/394230-listpopupmenu-refactoring'
FIXED-IN: 2.25.80 (KDE Applications 18.07.80)


https://commits.kde.org/umbrello/0bcf43aa0ff8a5cef25974917bf8513c0a679043

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=394230

--- Comment #2 from Ralf Habacker <***@freenet.de> ---
Git commit 81d90170b369cac6bb6d09f5f8478a06d11783fa by Ralf Habacker.
Committed on 25/07/2018 at 13:26.
Pushed by habacker into branch 'Applications/18.08'.

Position and presence of adding plain text unified using context menu for
diagrams and widgets

M +1 -0 umbrello/menus/umlscenepopupmenu.cpp
M +1 -1 umbrello/menus/widgetbasepopupmenu.cpp

https://commits.kde.org/umbrello/81d90170b369cac6bb6d09f5f8478a06d11783fa

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=394230

--- Comment #3 from Ralf Habacker <***@freenet.de> ---
Git commit 66b663bb6813ac58ec6602b2c37516deb863e230 by Ralf Habacker.
Committed on 25/07/2018 at 13:41.
Pushed by habacker into branch 'Applications/18.08'.

Fix position of adding note entry to context menu entries

It has to be added to the current menu, not the global one.

M +3 -3 umbrello/menus/listpopupmenu.cpp

https://commits.kde.org/umbrello/66b663bb6813ac58ec6602b2c37516deb863e230

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=394230

--- Comment #5 from Ralf Habacker <***@freenet.de> ---
Git commit 144c961de29e2351321b6631e2f0e901c927638a by Ralf Habacker.
Committed on 25/07/2018 at 14:11.
Pushed by habacker into branch 'Applications/18.08'.

Remove context menu entry for adding port on component diagrams

It does not make any sense to add a port when not on a widget.

M +0 -2 umbrello/menus/umlscenepopupmenu.cpp

https://commits.kde.org/umbrello/144c961de29e2351321b6631e2f0e901c927638a

--- Comment #4 from Ralf Habacker <***@freenet.de> ---
Git commit 63264ea741c32b33a1b6f95765bb643cdd729f33 by Ralf Habacker.
Committed on 25/07/2018 at 14:39.
Pushed by habacker into branch 'Applications/18.08'.

Never implemented context menu entry for adding a subsystem removed

Adding the implementation would require an extension of the translation
and the stable branch is frozen in this respect.

M +0 -1 umbrello/menus/umlscenepopupmenu.cpp

https://commits.kde.org/umbrello/63264ea741c32b33a1b6f95765bb643cdd729f33

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=394230

--- Comment #5 from Ralf Habacker <***@freenet.de> ---
Git commit 144c961de29e2351321b6631e2f0e901c927638a by Ralf Habacker.
Committed on 25/07/2018 at 14:11.
Pushed by habacker into branch 'Applications/18.08'.

Remove context menu entry for adding port on component diagrams

It does not make any sense to add a port when not on a widget.

M +0 -2 umbrello/menus/umlscenepopupmenu.cpp

https://commits.kde.org/umbrello/144c961de29e2351321b6631e2f0e901c927638a

--- Comment #4 from Ralf Habacker <***@freenet.de> ---
Git commit 63264ea741c32b33a1b6f95765bb643cdd729f33 by Ralf Habacker.
Committed on 25/07/2018 at 14:39.
Pushed by habacker into branch 'Applications/18.08'.

Never implemented context menu entry for adding a subsystem removed

Adding the implementation would require an extension of the translation
and the stable branch is frozen in this respect.

M +0 -1 umbrello/menus/umlscenepopupmenu.cpp

https://commits.kde.org/umbrello/63264ea741c32b33a1b6f95765bb643cdd729f33

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=394230

--- Comment #6 from Ralf Habacker <***@freenet.de> ---
Git commit 30fa4fcc0ab1d019d697fc48e2868b70f9d7597f by Ralf Habacker.
Committed on 25/07/2018 at 14:50.
Pushed by habacker into branch 'Applications/18.08'.

Never implemented context menu entry for adding a subsystem port removed

Adding the implementation would require an extension of the translation
and the stable branch is frozen in this respect.

M +0 -2 umbrello/menus/widgetbasepopupmenu.cpp

https://commits.kde.org/umbrello/30fa4fcc0ab1d019d697fc48e2868b70f9d7597f

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=394230

--- Comment #7 from Ralf Habacker <***@freenet.de> ---
Git commit dab5718899f3bc03f5aae6338ff4473d97f6af70 by Ralf Habacker.
Committed on 30/07/2018 at 16:05.
Pushed by habacker into branch 'Applications/18.08'.

Never implemented context menu entry for adding actor, usecase, component,
artifact and activity from a widget

Adding the implementation would require an extension of the translation
and the stable branch is frozen in this respect.

M +0 -12 umbrello/menus/widgetbasepopupmenu.cpp

https://commits.kde.org/umbrello/dab5718899f3bc03f5aae6338ff4473d97f6af70

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=394230

--- Comment #9 from Ralf Habacker <***@freenet.de> ---
Git commit 6377bb02345a82030ac7c0fa1b3bdea131cae6a6 by Ralf Habacker.
Committed on 17/09/2018 at 10:32.
Pushed by habacker into branch '394230-bug-fixing'.

Fix adding ports to components on component diagram

M +11 -0 umbrello/menus/widgetbasepopupmenu.cpp
M +15 -0 umbrello/umlwidgets/umlwidget.cpp

https://commits.kde.org/umbrello/6377bb02345a82030ac7c0fa1b3bdea131cae6a6

--- Comment #8 from Ralf Habacker <***@freenet.de> ---
Git commit 50d24f7cef29d492eb0ac164a84c511374400815 by Ralf Habacker.
Committed on 17/09/2018 at 10:31.
Pushed by habacker into branch '394230-bug-fixing'.

Fix adding subsystem from context menu to component diagrams

M +1 -0 umbrello/menus/umlscenepopupmenu.cpp
M +12 -0 umbrello/umlscene.cpp

https://commits.kde.org/umbrello/50d24f7cef29d492eb0ac164a84c511374400815

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=394230

--- Comment #11 from Ralf Habacker <***@freenet.de> ---
Git commit 4af37ad57f6622f49fb0ebe2a874b19c9cec5f00 by Ralf Habacker.
Committed on 05/10/2018 at 22:15.
Pushed by habacker into branch 'master'.

Fix adding ports to components on component diagram

M +11 -0 umbrello/menus/widgetbasepopupmenu.cpp
M +15 -0 umbrello/umlwidgets/umlwidget.cpp

https://commits.kde.org/umbrello/4af37ad57f6622f49fb0ebe2a874b19c9cec5f00

--- Comment #10 from Ralf Habacker <***@freenet.de> ---
Git commit a8dbaba8164ff1660e4fdfcf7c961f0fd6dd2b76 by Ralf Habacker.
Committed on 05/10/2018 at 22:15.
Pushed by habacker into branch 'master'.

Fix adding subsystem from context menu to component diagrams

M +1 -0 umbrello/menus/umlscenepopupmenu.cpp
M +12 -0 umbrello/umlscene.cpp

https://commits.kde.org/umbrello/a8dbaba8164ff1660e4fdfcf7c961f0fd6dd2b76

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=394230

--- Comment #12 from Ralf Habacker <***@freenet.de> ---
Git commit 6cb829c7d474edeb4073b385daa6cdad9853ca22 by Ralf Habacker.
Committed on 05/10/2018 at 23:25.
Pushed by habacker into branch 'master'.

Refactor adding menu entries from action collection

M +22 -26 umbrello/menus/listpopupmenu.cpp
M +1 -0 umbrello/menus/listpopupmenu.h

https://commits.kde.org/umbrello/6cb829c7d474edeb4073b385daa6cdad9853ca22